Regan gave more money to Iran than Obama.
Trump
Pros
Embassy
Iran
Verbal support
Cons
Verbal attack on settlements
Maybe it's Trump, someone add to the list and we'll do the math.
I don't think Trump himself condemned the settlements... But I know members of his cabinet/administration did. I think someone called them 'occupied', and they have had quarrels with Trump's Israeli Ambassador (Friedman) about not calling them Judea-Samaria, But from Trump himself, I remember he tweeted, 'Keep building in Judea-Samaria' last year.
The problem is that Trump rushed his cabinet/transition team... it was sloppy... and its still is full of RINO's. Lets not forget his horrible pick for Sec of State, 'Tillerson', who was so far left, that he insisted we keep the Iran deal. All these RINO cabinet picks that have come back to bite him.
I know that early-on Trump seemed like he'd be ok with the two-state solution, but I think there are reasons to be optimistic. From what I've heard... Trump is trying to undo the stupidity of Bush. Remember, it was Bush who pushed the 'two-state' solution into the republican narrative, and many of the RINO's followed his lead. I heard Friedman recently say that nobody in his circle even mentions the two-state solution anymore. Who knows.... but I can safely say that Trump is certainly better than Bush.